Ace 1568 Proxy support changes #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchougule
reviewed
Nov 6, 2020
rchougule
suggested changes
Nov 6, 2020
rchougule
suggested changes
Nov 6, 2020
rchougule
reviewed
Nov 6, 2020
| this.authentication = new BasicAuthentication(this.username, this.accessKey); | ||
| } | ||
|
|
||
| public void setProxy(String proxyHost, int proxyPort, String proxyUsername, String proxyPassword) { |
There was a problem hiding this comment.
so will this method be called by the client using this package? as in... in jenkins plugin..
There was a problem hiding this comment.
Add javadoc comment for this function since it plays an important role of setting the proxy.
Something like: https://github.com/browserstack/automate-client-java/blob/master/src/main/java/com/browserstack/automate/AutomateClient.java#L41-L46
There was a problem hiding this comment.
Suggested change
| public void setProxy(String proxyHost, int proxyPort, String proxyUsername, String proxyPassword) { | |
| public void setProxy(final String proxyHost, final int proxyPort, final String proxyUsername, final String proxyPassword) { |
rchougule
reviewed
Nov 6, 2020
Archish27
reviewed
Nov 6, 2020
…ack/automate-client-java into ACE-1568-apache-implementation
rchougule
reviewed
Nov 6, 2020
rchougule
reviewed
Nov 6, 2020
Archish27
reviewed
Nov 6, 2020
Making variables final Co-authored-by: Archish Thakkar <[email protected]>
rchougule
reviewed
Nov 6, 2020
src/main/java/com/browserstack/client/BrowserStackClientInterface.java
Outdated
Show resolved
Hide resolved
Archish27
approved these changes
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RELATED PR
https://github.com/jenkinsci/browserstack-integration-plugin/pull/28/files
Jenkins plugin support for proxy (Browserstack plugin changes)